Fix playing adventure sounds on World/Server #8077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
fix/adventure-world-sounds
branch
from
7f8a811 to
a42ad60
Compare
Machine-Maker
force-pushed
the
fix/adventure-world-sounds
branch
from
a42ad60 to
98137cd
Compare
Machine-Maker
force-pushed
the
fix/adventure-world-sounds
branch
2 times, most recently
from
3e82bd5 to
f34f1e3
Compare
Machine-Maker
changed the title
|
Rebased for 1.19.3 |
Machine-Maker
force-pushed
the
fix/adventure-world-sounds
branch
from
f34f1e3 to
78da3dc
Compare
kashike
approved these changes
Feb 24, 2023
Machine-Maker
force-pushed
the
fix/adventure-world-sounds
branch
from
78da3dc to
f7aa173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playing adventure sounds on a World/Server had some unexpected side effects due to ForwardingAudience's delegation to each individual audience. This overrides all 3 playSound methods in CraftWorld/CraftServer with better implementations.
The issues arrises due to seeded sounds. When you play a sound on a World or Server without a seed, it should pick one seed. For location-specific sounds on World/Server, packets shouldn't be sent to all players, only players within range, so overriding also allows delegation to vanilla packet broadcast mechanics.