Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify submit button parsing #215

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Simplify submit button parsing #215

merged 2 commits into from
Oct 18, 2021

Conversation

PaperStrike
Copy link
Owner

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PaperStrike
Simplify submit button parsing
75bfb60 
* Considering a submit event ensures the submitter attribute to denote a submit button or null, remove the related algorithm.
* Add more comments about the potential changes to submit buttons.
@PaperStrike PaperStrike added the enhancement New feature or request label Oct 18, 2021
@PaperStrike PaperStrike merged commit 2210a98 into main Oct 18, 2021
@PaperStrike PaperStrike deleted the spec-submit-btn branch October 18, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaperStrike