chore(rethinkdb): OrganizationUser: Phase 3 (#9965)

Signed-off-by: Matt Krick <[email protected]>

codegen.json

@@ -92,7 +92,7 @@
           "NotifyTaskInvolves": "../../database/types/NotificationTaskInvolves#default",
           "NotifyTeamArchived": "../../database/types/NotificationTeamArchived#default",
           "Organization": "./types/Organization#OrganizationSource",
-          "OrganizationUser": "../../database/types/OrganizationUser#default as OrganizationUser",
+          "OrganizationUser": "../../postgres/types/index#OrganizationUser",
           "PokerMeeting": "../../database/types/MeetingPoker#default as MeetingPoker",
           "PokerMeetingMember": "../../database/types/MeetingPokerMeetingMember#default as PokerMeetingMemberDB",
           "PokerTemplate": "../../database/types/PokerTemplate#default as PokerTemplateDB",

packages/server/__tests__/globalTeardown.ts

@@ -1,8 +1,12 @@
 import getRethink from '../database/rethinkDriver'
+import getKysely from '../postgres/getKysely'
+import getRedis from '../utils/getRedis'
 
 async function teardown() {
   const r = await getRethink()
-  return r.getPoolMaster()?.drain()
+  await r.getPoolMaster()?.drain()
+  await getKysely().destroy()
+  await getRedis().quit()
 }
 
 export default teardown

packages/server/billing/helpers/adjustUserCount.ts

@@ -1,15 +1,12 @@
 import {sql} from 'kysely'
 import {InvoiceItemType} from 'parabol-client/types/constEnums'
-import getRethink from '../../database/rethinkDriver'
-import {RDatum} from '../../database/stricterR'
-import OrganizationUser from '../../database/types/OrganizationUser'
+import generateUID from '../../generateUID'
 import {DataLoaderWorker} from '../../graphql/graphql'
 import isValid from '../../graphql/isValid'
 import getKysely from '../../postgres/getKysely'
 import insertOrgUserAudit from '../../postgres/helpers/insertOrgUserAudit'
 import {OrganizationUserAuditEventTypeEnum} from '../../postgres/queries/generated/insertOrgUserAuditQuery'
 import {getUserById} from '../../postgres/queries/getUsersByIds'
-import updateUser from '../../postgres/queries/updateUser'
 import IUser from '../../postgres/types/IUser'
 import {Logger} from '../../utils/Logger'
 import {analytics} from '../../utils/analytics/analytics'
@@ -45,39 +42,25 @@ const maybeUpdateOrganizationActiveDomain = async (
 }
 
 const changePause = (inactive: boolean) => async (_orgIds: string[], user: IUser) => {
-  const r = await getRethink()
+  const pg = getKysely()
   const {id: userId, email} = user
   inactive ? analytics.accountPaused(user) : analytics.accountUnpaused(user)
   analytics.identify({
     userId,
     email,
     isActive: !inactive
   })
-  await Promise.all([
-    updateUser(
-      {
-        inactive
-      },
-      userId
-    ),
-    getKysely()
-      .updateTable('OrganizationUser')
-      .set({inactive})
-      .where('userId', '=', userId)
-      .where('removedAt', 'is', null)
-      .execute(),
-    r
-      .table('OrganizationUser')
-      .getAll(userId, {index: 'userId'})
-      .filter({removedAt: null})
-      .update({inactive})
-      .run()
-  ])
+  await pg
+    .with('User', (qb) => qb.updateTable('User').set({inactive}).where('id', '=', userId))
+    .updateTable('OrganizationUser')
+    .set({inactive})
+    .where('userId', '=', userId)
+    .where('removedAt', 'is', null)
+    .execute()
 }
 
 const addUser = async (orgIds: string[], user: IUser, dataLoader: DataLoaderWorker) => {
   const {id: userId} = user
-  const r = await getRethink()
   const [rawOrganizations, organizationUsers] = await Promise.all([
     dataLoader.get('organizations').loadMany(orgIds),
     dataLoader.get('organizationUsersByUserId').load(userId)
@@ -90,19 +73,18 @@ const addUser = async (orgIds: string[], user: IUser, dataLoader: DataLoaderWork
     )
     const organization = organizations.find((organization) => organization.id === orgId)!
     // continue the grace period from before, if any OR set to the end of the invoice OR (if it is a free account) no grace period
-    return new OrganizationUser({
-      id: oldOrganizationUser?.id,
+    return {
+      id: oldOrganizationUser?.id || generateUID(),
       orgId,
       userId,
       tier: organization.tier
-    })
+    }
   })
   await getKysely()
     .insertInto('OrganizationUser')
     .values(docs)
     .onConflict((oc) => oc.doNothing())
     .execute()
-  await r.table('OrganizationUser').insert(docs, {conflict: 'replace'}).run()
   await Promise.all(
     orgIds.map((orgId) => {
       return maybeUpdateOrganizationActiveDomain(orgId, user.email, dataLoader)
@@ -111,22 +93,13 @@ const addUser = async (orgIds: string[], user: IUser, dataLoader: DataLoaderWork
 }
 
 const deleteUser = async (orgIds: string[], user: IUser) => {
-  const r = await getRethink()
   orgIds.forEach((orgId) => analytics.userRemovedFromOrg(user, orgId))
   await getKysely()
     .updateTable('OrganizationUser')
     .set({removedAt: sql`CURRENT_TIMESTAMP`})
     .where('userId', '=', user.id)
     .where('orgId', 'in', orgIds)
     .execute()
-  await r
-    .table('OrganizationUser')
-    .getAll(user.id, {index: 'userId'})
-    .filter((row: RDatum) => r.expr(orgIds).contains(row('orgId')))
-    .update({
-      removedAt: new Date()
-    })
-    .run()
 }
 
 const dbActionTypeLookup = {

packages/server/billing/helpers/teamLimitsCheck.ts

@@ -28,12 +28,6 @@ const enableUsageStats = async (userIds: string[], orgId: string) => {
     .where('userId', 'in', userIds)
     .where('removedAt', 'is', null)
     .execute()
-  await r
-    .table('OrganizationUser')
-    .getAll(r.args(userIds), {index: 'userId'})
-    .filter({orgId})
-    .update({suggestedTier: 'team'})
-    .run()
   await pg
     .updateTable('User')
     .set({featureFlags: sql`arr_append_uniq("featureFlags", 'insights')`})
@@ -101,12 +95,6 @@ export const maybeRemoveRestrictions = async (orgId: string, dataLoader: DataLoa
         .where('userId', 'in', billingLeadersIds)
         .where('removedAt', 'is', null)
         .execute(),
-      r
-        .table('OrganizationUser')
-        .getAll(r.args(billingLeadersIds), {index: 'userId'})
-        .filter({orgId})
-        .update({suggestedTier: 'starter'})
-        .run(),
       removeTeamsLimitObjects(orgId, dataLoader)
     ])
     dataLoader.get('organizations').clear(orgId)

packages/server/billing/helpers/updateSubscriptionQuantity.ts

@@ -1,4 +1,3 @@
-import getRethink from '../../database/rethinkDriver'
 import getKysely from '../../postgres/getKysely'
 import insertStripeQuantityMismatchLogging from '../../postgres/queries/insertStripeQuantityMismatchLogging'
 import RedisLockQueue from '../../utils/RedisLockQueue'
@@ -10,7 +9,6 @@ import {getStripeManager} from '../../utils/stripe'
  * @param logMismatch Pass true if a quantity mismatch should be logged
  */
 const updateSubscriptionQuantity = async (orgId: string, logMismatch?: boolean) => {
-  const r = await getRethink()
   const pg = getKysely()
   const manager = getStripeManager()
 
@@ -35,29 +33,17 @@ const updateSubscriptionQuantity = async (orgId: string, logMismatch?: boolean)
       return
     }
 
-    const [orgUserCountRes, orgUserCount, teamSubscription] = await Promise.all([
+    const [orgUserCountRes, teamSubscription] = await Promise.all([
       pg
         .selectFrom('OrganizationUser')
         .select(({fn}) => fn.count<number>('id').as('count'))
         .where('orgId', '=', orgId)
         .where('removedAt', 'is', null)
         .where('inactive', '=', false)
         .executeTakeFirstOrThrow(),
-      r
-        .table('OrganizationUser')
-        .getAll(orgId, {index: 'orgId'})
-        .filter({removedAt: null, inactive: false})
-        .count()
-        .run(),
       manager.getSubscriptionItem(stripeSubscriptionId)
     ])
-    if (orgUserCountRes.count !== orgUserCount) {
-      sendToSentry(new Error('OrganizationUser count mismatch'), {
-        tags: {
-          orgId
-        }
-      })
-    }
+    const {count: orgUserCount} = orgUserCountRes
     if (
       teamSubscription &&
       teamSubscription.quantity !== undefined &&

packages/server/database/rethinkDriver.ts

@@ -25,7 +25,6 @@ import NotificationResponseReplied from './types/NotificationResponseReplied'
 import NotificationTaskInvolves from './types/NotificationTaskInvolves'
 import NotificationTeamArchived from './types/NotificationTeamArchived'
 import NotificationTeamInvitation from './types/NotificationTeamInvitation'
-import OrganizationUser from './types/OrganizationUser'
 import PasswordResetRequest from './types/PasswordResetRequest'
 import PushInvitation from './types/PushInvitation'
 import RetrospectivePrompt from './types/RetrospectivePrompt'
@@ -112,10 +111,6 @@ export type RethinkSchema = {
       | NotificationMentioned
     index: 'userId'
   }
-  OrganizationUser: {
-    type: OrganizationUser
-    index: 'orgId' | 'userId'
-  }
   PasswordResetRequest: {
     type: PasswordResetRequest
     index: 'email' | 'ip' | 'token'

packages/server/dataloader/__tests__/isOrgVerified.test.ts

@@ -1,56 +1,19 @@
 /* eslint-env jest */
 import {Insertable} from 'kysely'
-import {r} from 'rethinkdb-ts'
 import {createPGTables, truncatePGTables} from '../../__tests__/common'
-import getRethinkConfig from '../../database/getRethinkConfig'
-import getRethink from '../../database/rethinkDriver'
-import OrganizationUser from '../../database/types/OrganizationUser'
 import generateUID from '../../generateUID'
 import getKysely from '../../postgres/getKysely'
 import {User} from '../../postgres/pg'
-import getRedis from '../../utils/getRedis'
-import isUserVerified from '../../utils/isUserVerified'
+import {OrganizationUser} from '../../postgres/types'
 import RootDataLoader from '../RootDataLoader'
-jest.mock('../../database/rethinkDriver')
-jest.mock('../../utils/isUserVerified')
-
-jest.mocked(getRethink).mockImplementation(() => {
-  return r as any
-})
-
-jest.mocked(isUserVerified).mockImplementation(() => {
-  return true
-})
 
 const TEST_DB = 'getVerifiedOrgIdsTest'
 
-const config = getRethinkConfig()
-const testConfig = {
-  ...config,
-  db: TEST_DB
-}
-
 type TestUser = Insertable<User>
 const addUsers = async (users: TestUser[]) => {
   return getKysely().insertInto('User').values(users).execute()
 }
 
-const createTables = async (...tables: string[]) => {
-  for (const tableName of tables) {
-    const structure = await r
-      .db('rethinkdb')
-      .table('table_config')
-      .filter({db: config.db, name: tableName})
-      .run()
-    await r.tableCreate(tableName).run()
-    const {indexes} = structure[0]
-    for (const index of indexes) {
-      await r.table(tableName).indexCreate(index).run()
-    }
-    await r.table(tableName).indexWait().run()
-  }
-}
-
 type TestOrganizationUser = Partial<
   Pick<OrganizationUser, 'inactive' | 'joinedAt' | 'removedAt' | 'role' | 'userId'>
 >
@@ -90,35 +53,21 @@ const addOrg = async (
     await pg.insertInto('Organization').values(org).execute()
   }
 
-  await r.table('OrganizationUser').insert(orgUsers).run()
   return orgId
 }
 
 beforeAll(async () => {
-  await r.connectPool(testConfig)
   const pg = getKysely(TEST_DB)
-
-  try {
-    await r.dbDrop(TEST_DB).run()
-  } catch (e) {
-    //ignore
-  }
   await pg.schema.createSchema(TEST_DB).ifNotExists().execute()
-
-  await r.dbCreate(TEST_DB).run()
   await createPGTables('Organization', 'User', 'SAML', 'SAMLDomain', 'OrganizationUser')
-  await createTables('OrganizationUser')
 })
 
 afterEach(async () => {
-  await truncatePGTables('Organization', 'User')
-  await r.table('OrganizationUser').delete().run()
+  await truncatePGTables('Organization', 'User', 'OrganizationUser')
 })
 
 afterAll(async () => {
-  await r.getPoolMaster()?.drain()
   await getKysely().destroy()
-  getRedis().quit()
 })
 
 test('Founder is billing lead', async () => {