feat: Update MeetingTemplate.updatedAt on prompt changes (#9829)

ParabolInc · Jun 10, 2024 · e614253 · e614253
1 parent bd37d85
commit e614253
Show file tree

Hide file tree

Showing 19 changed files with 230 additions and 65 deletions.
diff --git a/packages/server/database/rethinkDriver.ts b/packages/server/database/rethinkDriver.ts
@@ -197,7 +197,7 @@ export type RethinkSchema = {
   }
   TemplateDimension: {
     type: TemplateDimension
-    index: 'teamId' | 'templateId'
+    index: 'teamId' | 'templateId' | 'scaleId'
   }
   TemplateScale: {
     type: TemplateScale

diff --git a/packages/server/graphql/mutations/addPokerTemplateDimension.ts b/packages/server/graphql/mutations/addPokerTemplateDimension.ts
@@ -4,6 +4,7 @@ import dndNoise from 'parabol-client/utils/dndNoise'
 import getRethink from '../../database/rethinkDriver'
 import {RDatum} from '../../database/stricterR'
 import TemplateDimension from '../../database/types/TemplateDimension'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -24,6 +25,7 @@ const addPokerTemplateDimension = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
     const template = await dataLoader.get('meetingTemplates').load(templateId)
@@ -73,7 +75,14 @@ const addPokerTemplateDimension = {
       templateId
     })
 
-    await r.table('TemplateDimension').insert(newDimension).run()
+    await Promise.all([
+      r.table('TemplateDimension').insert(newDimension).run(),
+      pg
+        .updateTable('MeetingTemplate')
+        .set({updatedAt: new Date()})
+        .where('id', '=', templateId)
+        .execute()
+    ])
 
     const dimensionId = newDimension.id
     const data = {dimensionId}

diff --git a/packages/server/graphql/mutations/addPokerTemplateScaleValue.ts b/packages/server/graphql/mutations/addPokerTemplateScaleValue.ts
@@ -3,6 +3,7 @@ import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
 import {RDatum} from '../../database/stricterR'
 import TemplateScale from '../../database/types/TemplateScale'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -32,6 +33,7 @@ const addPokerTemplateScaleValue = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -84,6 +86,18 @@ const addPokerTemplateScaleValue = {
       })
     }
 
+    // mark all templates using this scale as updated
+    const updatedDimensions = await r
+      .table('TemplateDimension')
+      .getAll(scaleId, {index: 'scaleId'})
+      .run()
+    const updatedTemplateIds = updatedDimensions.map(({templateId}) => templateId)
+    await pg
+      .updateTable('MeetingTemplate')
+      .set({updatedAt: now})
+      .where('id', 'in', updatedTemplateIds)
+      .execute()
+
     const data = {scaleId}
     publish(
       SubscriptionChannel.TEAM,

diff --git a/packages/server/graphql/mutations/addReflectTemplatePrompt.ts b/packages/server/graphql/mutations/addReflectTemplatePrompt.ts
@@ -5,6 +5,7 @@ import palettePickerOptions from '../../../client/styles/palettePickerOptions'
 import {PALETTE} from '../../../client/styles/paletteV3'
 import getRethink from '../../database/rethinkDriver'
 import RetrospectivePrompt from '../../database/types/RetrospectivePrompt'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -25,6 +26,7 @@ const addReflectTemplatePrompt = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
     const template = await dataLoader.get('meetingTemplates').load(templateId)
@@ -69,7 +71,14 @@ const addReflectTemplatePrompt = {
       removedAt: null
     })
 
-    await r.table('ReflectPrompt').insert(reflectPrompt).run()
+    await Promise.all([
+      await r.table('ReflectPrompt').insert(reflectPrompt).run(),
+      pg
+        .updateTable('MeetingTemplate')
+        .set({updatedAt: new Date()})
+        .where('id', '=', templateId)
+        .execute()
+    ])
 
     const promptId = reflectPrompt.id
     const data = {promptId}

diff --git a/packages/server/graphql/mutations/movePokerTemplateDimension.ts b/packages/server/graphql/mutations/movePokerTemplateDimension.ts
@@ -1,6 +1,7 @@
 import {GraphQLFloat, GraphQLID, GraphQLNonNull} from 'graphql'
 import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -24,6 +25,7 @@ const movePokerTemplateDimension = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -39,16 +41,20 @@ const movePokerTemplateDimension = {
     }
 
     // RESOLUTION
-    await r
-      .table('TemplateDimension')
-      .get(dimensionId)
-      .update({
-        sortOrder,
-        updatedAt: now
-      })
-      .run()
+    const {teamId, templateId} = dimension
+
+    await Promise.all([
+      r
+        .table('TemplateDimension')
+        .get(dimensionId)
+        .update({
+          sortOrder,
+          updatedAt: now
+        })
+        .run(),
+      pg.updateTable('MeetingTemplate').set({updatedAt: now}).where('id', '=', templateId).execute()
+    ])
 
-    const {teamId} = dimension
     const data = {dimensionId}
     publish(SubscriptionChannel.TEAM, teamId, 'MovePokerTemplateDimensionPayload', data, subOptions)
     return data

diff --git a/packages/server/graphql/mutations/movePokerTemplateScaleValue.ts b/packages/server/graphql/mutations/movePokerTemplateScaleValue.ts
@@ -2,6 +2,7 @@ import {GraphQLID, GraphQLInt, GraphQLNonNull, GraphQLString} from 'graphql'
 import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
 import {RValue} from '../../database/stricterR'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -30,6 +31,7 @@ const movePokerTemplateScaleValue = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) => {
     const r = await getRethink()
+    const pg = getKysely()
     const viewerId = getUserId(authToken)
     const now = new Date()
     const operationId = dataLoader.share()
@@ -66,6 +68,17 @@ const movePokerTemplateScaleValue = {
         updatedAt: now
       }))
       .run()
+    // mark all templates using this scale as updated
+    const updatedDimensions = await r
+      .table('TemplateDimension')
+      .getAll(scaleId, {index: 'scaleId'})
+      .run()
+    const updatedTemplateIds = updatedDimensions.map(({templateId}) => templateId)
+    await pg
+      .updateTable('MeetingTemplate')
+      .set({updatedAt: now})
+      .where('id', 'in', updatedTemplateIds)
+      .execute()
 
     const data = {scaleId}
     publish(

diff --git a/packages/server/graphql/mutations/moveReflectTemplatePrompt.ts b/packages/server/graphql/mutations/moveReflectTemplatePrompt.ts
@@ -1,6 +1,7 @@
 import {GraphQLFloat, GraphQLID, GraphQLNonNull} from 'graphql'
 import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -24,6 +25,7 @@ const moveReflectTemplate = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -39,16 +41,20 @@ const moveReflectTemplate = {
     }
 
     // RESOLUTION
-    await r
-      .table('ReflectPrompt')
-      .get(promptId)
-      .update({
-        sortOrder,
-        updatedAt: now
-      })
-      .run()
+    const {teamId, templateId} = prompt
+
+    await Promise.all([
+      r
+        .table('ReflectPrompt')
+        .get(promptId)
+        .update({
+          sortOrder,
+          updatedAt: now
+        })
+        .run(),
+      pg.updateTable('MeetingTemplate').set({updatedAt: now}).where('id', '=', templateId).execute()
+    ])
 
-    const {teamId} = prompt
     const data = {promptId}
     publish(SubscriptionChannel.TEAM, teamId, 'MoveReflectTemplatePromptPayload', data, subOptions)
     return data

diff --git a/packages/server/graphql/mutations/reflectTemplatePromptUpdateDescription.ts b/packages/server/graphql/mutations/reflectTemplatePromptUpdateDescription.ts
@@ -1,6 +1,7 @@
 import {GraphQLID, GraphQLNonNull, GraphQLString} from 'graphql'
 import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -24,6 +25,7 @@ const reflectTemplatePromptUpdateDescription = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -39,18 +41,21 @@ const reflectTemplatePromptUpdateDescription = {
     }
 
     // VALIDATION
-    const {teamId} = prompt
+    const {teamId, templateId} = prompt
     const normalizedDescription = description.trim().slice(0, 256) || ''
 
     // RESOLUTION
-    await r
-      .table('ReflectPrompt')
-      .get(promptId)
-      .update({
-        description: normalizedDescription,
-        updatedAt: now
-      })
-      .run()
+    await Promise.all([
+      r
+        .table('ReflectPrompt')
+        .get(promptId)
+        .update({
+          description: normalizedDescription,
+          updatedAt: now
+        })
+        .run(),
+      pg.updateTable('MeetingTemplate').set({updatedAt: now}).where('id', '=', templateId).execute()
+    ])
 
     const data = {promptId}
     publish(

diff --git a/packages/server/graphql/mutations/reflectTemplatePromptUpdateGroupColor.ts b/packages/server/graphql/mutations/reflectTemplatePromptUpdateGroupColor.ts
@@ -1,6 +1,7 @@
 import {GraphQLID, GraphQLNonNull, GraphQLString} from 'graphql'
 import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -24,6 +25,7 @@ const reflectTemplatePromptUpdateGroupColor = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -40,17 +42,20 @@ const reflectTemplatePromptUpdateGroupColor = {
     }
 
     // VALIDATION
-    const {teamId} = prompt
+    const {teamId, templateId} = prompt
 
     // RESOLUTION
-    await r
-      .table('ReflectPrompt')
-      .get(promptId)
-      .update({
-        groupColor,
-        updatedAt: now
-      })
-      .run()
+    await Promise.all([
+      r
+        .table('ReflectPrompt')
+        .get(promptId)
+        .update({
+          groupColor,
+          updatedAt: now
+        })
+        .run(),
+      pg.updateTable('MeetingTemplate').set({updatedAt: now}).where('id', '=', templateId).execute()
+    ])
 
     const data = {promptId}
     publish(

diff --git a/packages/server/graphql/mutations/removePokerTemplateDimension.ts b/packages/server/graphql/mutations/removePokerTemplateDimension.ts
@@ -2,6 +2,7 @@ import {GraphQLID, GraphQLNonNull} from 'graphql'
 import {SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
 import {RDatum} from '../../database/stricterR'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -22,6 +23,7 @@ const removePokerTemplateDimension = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -52,7 +54,10 @@ const removePokerTemplateDimension = {
     }
 
     // RESOLUTION
-    await r.table('TemplateDimension').get(dimensionId).update({removedAt: now}).run()
+    await Promise.all([
+      r.table('TemplateDimension').get(dimensionId).update({removedAt: now}).run(),
+      pg.updateTable('MeetingTemplate').set({updatedAt: now}).where('id', '=', templateId).execute()
+    ])
 
     const data = {dimensionId, templateId}
     publish(

diff --git a/packages/server/graphql/mutations/removePokerTemplateScale.ts b/packages/server/graphql/mutations/removePokerTemplateScale.ts
@@ -2,6 +2,7 @@ import {GraphQLID, GraphQLNonNull} from 'graphql'
 import {SprintPokerDefaults, SubscriptionChannel} from 'parabol-client/types/constEnums'
 import getRethink from '../../database/rethinkDriver'
 import {RDatum} from '../../database/stricterR'
+import getKysely from '../../postgres/getKysely'
 import {getUserId, isTeamMember} from '../../utils/authorization'
 import publish from '../../utils/publish'
 import standardError from '../../utils/standardError'
@@ -22,6 +23,7 @@ const removePokerTemplateScale = {
     {authToken, dataLoader, socketId: mutatorId}: GQLContext
   ) {
     const r = await getRethink()
+    const pg = getKysely()
     const now = new Date()
     const operationId = dataLoader.share()
     const subOptions = {operationId, mutatorId}
@@ -56,6 +58,13 @@ const removePokerTemplateScale = {
       )('changes')('new_val')
       .default([])
       .run()
+    // mark templates as updated
+    const updatedTemplateIds = dimensions.map(({templateId}: any) => templateId)
+    await pg
+      .updateTable('MeetingTemplate')
+      .set({updatedAt: now})
+      .where('id', 'in', updatedTemplateIds)
+      .execute()
 
     const data = {scaleId, dimensions}
     publish(SubscriptionChannel.TEAM, teamId, 'RemovePokerTemplateScalePayload', data, subOptions)