Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Flow Tech Debt: retry invoice after updating payment method #8452

Closed
1 task
nickoferrall opened this issue Jun 28, 2023 · 3 comments · Fixed by #8478
Closed
1 task

Checkout Flow Tech Debt: retry invoice after updating payment method #8452

nickoferrall opened this issue Jun 28, 2023 · 3 comments · Fixed by #8478
Assignees
Labels

Comments

@nickoferrall
Copy link
Contributor

See #8423 (comment) and #8285

AC

  • After updating the payment method, try to charge any invoices that previously failed
@igorlesnenko
Copy link
Contributor

@nickoferrall I'm not sure if it should be in v2.
The reason we added this is that sometimes the next payment for a new month does not go through for various reasons, then we lock the teams and offer to update the card so that the payment goes through and the teams are unblocked. Otherwise teams will be still locked

@nickoferrall
Copy link
Contributor Author

@igorlesnenko I've created a PR #8478 adding this, following your example here https://github.com/ParabolInc/parabol/pull/8285/files#diff-33495952ec45bdf9ae264bf5f1b208d5f88dc412a9d34ed5d8fc3c26a19ae310R64-R75.

One question:

If we fail to charge the open invoice, would we want to downgrade the org? Here the tier changes to team and then we try to charge any open invoices.

@igorlesnenko
Copy link
Contributor

@nickoferrall I think we ideally want to downgrade, I created an issue about this improvement: #8341

@nickoferrall nickoferrall changed the title Checkout Flow v2: retry invoice after updating payment method Checkout Flow Tech Debt: retry invoice after updating payment method Jul 11, 2023
@nickoferrall nickoferrall self-assigned this Jul 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧁Product Squad Self Raise Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

2 participants