Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): add timer control to more meeting phases #10279

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Oct 1, 2024

Description

Originated from this Slack message

Demo

Screenshot 2024-10-01 at 12 24 01

Testing scenarios

  • Poker meeting estimate phase

    • Start a poker meeting
    • Add some item to estimate
    • Advance to the estimate phase
    • See you can start a timer
  • Action meeting agenda item phase

    • Start an action meeting
    • Add some agenda items
    • Advance to the agenda item phase
    • See you can start a timer

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe merged commit 1c87753 into master Oct 2, 2024
8 checks passed
@tianrunhe tianrunhe deleted the feat/addTimerToMorePhases branch October 2, 2024 02:52
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants