feat: update org feature flags backend #10446

nickoferrall · 2024-11-01T16:46:12Z

This PR shows all of the org feature flags in the organization settings. Org admins can view the feature flags and toggle them, updating the backend.

This PR includes migrating noAISummary feature flag to useAI on the Organization object. It does not include toggling the useAI boolean in the db. I'll add that in a subsequent PR.

To test

Go to the Organization settings of an org where you're the org admin
Toggle the feature flags

github-actions · 2024-11-04T19:33:14Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-05T15:57:01Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-05T16:01:02Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-05T16:12:38Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-05T16:20:28Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-05T17:12:08Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-06T14:47:21Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-06T15:01:03Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-06T15:08:16Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-06T15:43:04Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-06T16:08:24Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Dschoordsch · 2024-11-12T14:44:33Z

packages/server/postgres/migrations/2024-10-31T14:42:16.120Z_add-use-ai-to-orgs.ts

+    )
+    .execute()
+
+  await db.deleteFrom('FeatureFlag').where('featureName', '=', 'noAISummary').execute()


+1 shouldn't this also delete cascade the 'FeatureFlagOwner' entries above?

True! It does delete cascade so I can remove that FeatureFlagOwner deletion

nickoferrall · 2024-11-12T16:18:47Z

Hey @mattkrick, bumping this review request 🙏

packages/server/dataloader/customLoaderMakers.ts

packages/server/postgres/types/pg.d.ts

mattkrick · 2024-11-14T22:49:59Z

packages/server/postgres/pg.d.ts

why is this here?

packages/server/graphql/public/types/ToggleFeatureFlagSuccess.ts

mattkrick · 2024-11-14T22:53:59Z

packages/server/graphql/public/typeDefs/FeatureFlag.graphql

@@ -18,4 +23,9 @@ type FeatureFlag {
  The scope of the feature flag
  """
  scope: FeatureFlagScope!
+
+  """
+  Whether the flag is enabled for an owner or not


-1 enabled is a property of FeatureFlagOwner, so a type like UpdateFeatureFlagSuccess that returns a FeatureFlag won't have enabled as a field. This is technically OK since enabled is optional, but it's not very expressive because we're basically using the same FeatureFlag type for 2 different types of objects (a FeatureFlag, and a FeatureFlagWithOwner). i would keep enabled off this object or make a second object like OwnedFeatureFlag to express that they're different

github-actions · 2024-11-15T16:10:44Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-11-15T16:15:51Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

packages/server/postgres/types/index.d.ts

mattkrick · 2024-11-15T18:34:58Z

packages/server/postgres/types/pg.d.ts

this shouldn't be in version control, right?

mattkrick · 2024-11-15T18:35:40Z

packages/server/graphql/public/typeDefs/ToggleFeatureFlagSuccess.graphql

+  """
+  The feature flag that was toggled
+  """
+  featureFlag: OwnedFeatureFlag!


curious, why create a new type vs. having {enabled, featureFlag}?

I think we need it here.

In ToggleFeatureFlagSuccess, we could do what you're suggesting, but in Organization, I think we do have to return a new type? I went with your suggestion here.

ah! that makes sense. LGTM

nickoferrall added 6 commits October 31, 2024 15:25

feat: add use ai to org

c2612ec

implement feature flag resolver and dataloaders to get all flags

ed8e516

implement toggle feature flag

c734ba1

update dataloader

5fff7ec

add checks in toggle feature flag mutation

e943ab4

feature flag subscription working

ebbbb67

github-actions bot added the size/xl label Nov 4, 2024

nickoferrall added 4 commits November 5, 2024 15:50

add lookup

412f30d

Merge branch 'feat/add-use-ai' into feat/org-feature-flags-dynamic

dde53d2

merge useAi

f447d71

clean up

52d0507

info icon centered

74f684f

nickoferrall changed the base branch from master to feat/add-use-ai November 5, 2024 16:01

fix codegen error

f0003d9

Revert changes to yarn.lock

ad7dc0e

fix ToggleFeatureFlagSuccess ts error

bb8f42e

update enabled type

c2e559d

nickoferrall marked this pull request as ready for review November 6, 2024 14:56

nickoferrall mentioned this pull request Nov 6, 2024

feat: add use ai to org #10437

Closed

1 task

nickoferrall changed the base branch from feat/add-use-ai to feat/feature-flags-ui November 6, 2024 14:58

Merge branch 'feat/feature-flags-ui' into feat/org-feature-flags-dynamic

7e81e1c

only org admin can see ui

85f77a6

nickoferrall requested a review from mattkrick November 6, 2024 15:13

update err message

fd693f6

update props

93fa3cf

Dschoordsch reviewed Nov 12, 2024

View reviewed changes

mattkrick reviewed Nov 14, 2024

View reviewed changes

seperate owned feature flag and feature flag

cf6af28

state validScope type

947178a

mattkrick reviewed Nov 15, 2024

View reviewed changes

packages/server/postgres/types/index.d.ts Outdated Show resolved Hide resolved

mattkrick reviewed Nov 15, 2024

View reviewed changes

nickoferrall added 2 commits November 18, 2024 17:27

chore: remove pg.d.ts from version control

0620a0d

update featureFlag type in index.d.ts

0d2fdae

github-actions bot added size/l and removed size/xl labels Nov 18, 2024

nickoferrall requested a review from mattkrick November 19, 2024 14:54

mattkrick approved these changes Nov 20, 2024

View reviewed changes

feat: implement toggle ai features mutation (#10457)

f1dd5c4

nickoferrall merged commit 3b44d51 into feat/feature-flags-ui Nov 20, 2024
7 checks passed

nickoferrall deleted the feat/org-feature-flags-dynamic branch November 20, 2024 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update org feature flags backend #10446

feat: update org feature flags backend #10446

nickoferrall commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

Dschoordsch Nov 12, 2024

nickoferrall Nov 12, 2024

nickoferrall commented Nov 12, 2024

mattkrick Nov 14, 2024

mattkrick Nov 14, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

mattkrick Nov 15, 2024

nickoferrall Nov 18, 2024

mattkrick Nov 15, 2024

nickoferrall Nov 18, 2024

mattkrick Nov 20, 2024

feat: update org feature flags backend #10446

feat: update org feature flags backend #10446

Conversation

nickoferrall commented Nov 1, 2024 • edited Loading

To test

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickoferrall commented Nov 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickoferrall commented Nov 1, 2024 •

edited

Loading