Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create mass invitation tokens for specific meetings #10651

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Jan 9, 2025

Description

Fixes #10354
Instead of just looking for the newest mass invite, check that the meeting matches as well.

Demo

https://www.loom.com/share/9e3bc0af500640d383ed28c07b1cff38?sid=5fb05a0d-c669-4b47-a9e3-7160c9c01c0d

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...
  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch marked this pull request as draft January 9, 2025 14:41
@github-actions github-actions bot added the size/s label Jan 9, 2025
@Dschoordsch Dschoordsch marked this pull request as ready for review January 14, 2025 13:00
@Dschoordsch Dschoordsch requested a review from mattkrick January 14, 2025 13:02
@Dschoordsch Dschoordsch merged commit 0516f8f into master Jan 16, 2025
7 checks passed
@Dschoordsch Dschoordsch deleted the fix/10354/inviteToSpecificMeeting branch January 16, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change invite link to be specific to a meeting, not most recently created
1 participant