Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group timeline events by relative dates #10708

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Jan 20, 2025

Description

Fixes this bet:

The “Scrum Knights” found our Timeline view to be cluttered. Let’s improve its organization by adding headers that group activities by time. Ideally we can determine an appropriate header frequency when presenting the meeting history (days, weeks, or months) dynamically.

Demo

Screenshot 2025-01-20 at 17 32 27

Testing scenarios

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe force-pushed the feat/groupedTimelines branch from 59c625d to 2973018 Compare January 20, 2025 09:31
@tianrunhe tianrunhe force-pushed the feat/groupedTimelines branch from 2973018 to 4006cb1 Compare January 20, 2025 09:44
@tianrunhe tianrunhe marked this pull request as ready for review January 20, 2025 10:00
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Looks great. I like the emoji choices

@tianrunhe tianrunhe merged commit 4b973a8 into master Jan 21, 2025
7 checks passed
@tianrunhe tianrunhe deleted the feat/groupedTimelines branch January 21, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants