chore(web-server): reconnect window can be manually set but keeps a 60s default value #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelromcar-parabol
changed the title
Dschoordsch
requested changes
Jan 30, 2025
packages/server/server.ts
Outdated
| @@ -34,10 +34,13 @@ tracer.init({ | |||
| tracer.use('ioredis').use('http').use('pg') | |||
|
|
|||
| process.on('SIGTERM', async (signal) => { | |||
| const RECONNECT_WINDOW = process.env.WEB_SERVER_RECONNECT_WINDOW | |||
| ? parseInt(process.env.WEB_SERVER_RECONNECT_WINDOW, 10) * 1000 | |||
| : 60_000 // ms | |||
There was a problem hiding this comment.
-1 We should move this top level. That way it's evaluated already on first importing the file and a NUMBER_FORMAT_EXCEPTION would interrupt startup. It's better than finding invalid environment variables only at runtime.
There was a problem hiding this comment.
Agree! Where is that? 🤔
There was a problem hiding this comment.
Just at the top of the file is fine, l27.
.env.example
Outdated
| @@ -54,6 +54,10 @@ FILE_STORE_PROVIDER='local' | |||
| # Google Cloud credentials are required to use FILE_STORE_PROVIDER='gcs' | |||
| # GOOGLE_GCS_BUCKET='BUCKET_NAME' | |||
|
|
|||
| # WEB SERVER | |||
| # Time window, in seconds, used by the web server to kick its users off. If empty, it has a default value. | |||
There was a problem hiding this comment.
+1 Maybe mention the default value? "If empty it defaults to 60s."
There was a problem hiding this comment.
Yeah, I wanted to avoid that, just in case we changed the default value one day. That said, minor change and clearer information so I'm adding that
Dschoordsch
approved these changes
Jan 30, 2025
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows setting a custom reconnect window for the web server, so it can gracefully stop in environments where 60s grace period isn't allowed.
Demo