-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agenda input prompt #626
Agenda input prompt #626
Conversation
I need to get the new copy edits in from S.P.A. |
Is this too stale or shall we revisit in Epic 3? |
Let's definitely put this in Epic 3. It's still important! |
Will revisit soon. |
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
=======================================
Coverage 60.09% 60.09%
=======================================
Files 124 124
Lines 1724 1724
=======================================
Hits 1036 1036
Misses 688 688
Continue to review full report at Codecov.
|
Small edits (I'd make 'em direct but @tayamueller and I are up against deadlines):
|
@jordanh got it!! Will update soon. |
@jordanh here is an empty Last Call and a Last Call with 3 items. An alternative to “That wraps up the agenda!” could be “Nice work, team!”. Also, any thoughts on copy for the Last Call empty state? I can update the copy. |
Looks good! will merge as soon as Jordan's 2 small edits get added. |
@mattkrick thanks! I made the changes he suggested. |
did you push? |
Ha, forgot to push! |
I’m using a specific heading (opposed to random) for both Last Call (some items) and Last Call (no items). |
ah gotcha. should we address the success message voice in this PR or do it in another one? |
Another PR, I’ll add it to my list! |
So far this fixes #732 #625 #631 and partially addresses #723 …
With a quick merge into master I can move on to other Epic 3 tasks, or I can add them to this PR (and re-title to Epic 3 part 2).
What say ye @mattkrick @jordanh ?