Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda input prompt #626

Merged
merged 11 commits into from
Apr 6, 2017
Merged

Agenda input prompt #626

merged 11 commits into from
Apr 6, 2017

Conversation

ackernaut
Copy link
Member

@ackernaut ackernaut commented Jan 11, 2017

So far this fixes #732 #625 #631 and partially addresses #723

With a quick merge into master I can move on to other Epic 3 tasks, or I can add them to this PR (and re-title to Epic 3 part 2).

What say ye @mattkrick @jordanh ?

@ackernaut
Copy link
Member Author

I need to get the new copy edits in from S.P.A.

@ackernaut
Copy link
Member Author

Is this too stale or shall we revisit in Epic 3?

@jordanh
Copy link
Contributor

jordanh commented Mar 10, 2017

Let's definitely put this in Epic 3. It's still important!

@ackernaut
Copy link
Member Author

Will revisit soon.

@codecov
Copy link

codecov bot commented Apr 6, 2017

Codecov Report

Merging #626 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #626   +/-   ##
=======================================
  Coverage   60.09%   60.09%           
=======================================
  Files         124      124           
  Lines        1724     1724           
=======================================
  Hits         1036     1036           
  Misses        688      688
Impacted Files Coverage Δ
src/universal/styles/ui.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92770b8...a32bbcb. Read the comment docs.

@ackernaut
Copy link
Member Author

Latest screens:

screenshot 2017-04-06 11 24 29
screenshot 2017-04-06 11 24 37
screenshot 2017-04-06 11 24 42

@jordanh
Copy link
Contributor

jordanh commented Apr 6, 2017

Small edits (I'd make 'em direct but @tayamueller and I are up against deadlines):

  1. Now...what -> Now, what do you need?
  2. Exnay on the Woot, woot. Let's update that voice. Could you suggest some new copy that is in voice?

@ackernaut
Copy link
Member Author

@jordanh got it!! Will update soon.

@ackernaut
Copy link
Member Author

@jordanh here is an empty Last Call and a Last Call with 3 items. An alternative to “That wraps up the agenda!” could be “Nice work, team!”. Also, any thoughts on copy for the Last Call empty state? I can update the copy.

screenshot 2017-04-06 13 16 00

screenshot 2017-04-06 13 17 40

@mattkrick
Copy link
Member

Looks good! will merge as soon as Jordan's 2 small edits get added.

@ackernaut
Copy link
Member Author

@mattkrick thanks! I made the changes he suggested.

@mattkrick
Copy link
Member

@ackernaut
Copy link
Member Author

Ha, forgot to push!

@ackernaut
Copy link
Member Author

I’m using a specific heading (opposed to random) for both Last Call (some items) and Last Call (no items).

@mattkrick
Copy link
Member

ah gotcha. should we address the success message voice in this PR or do it in another one?

@ackernaut
Copy link
Member Author

Another PR, I’ll add it to my list!

@mattkrick mattkrick merged commit 6d7a2e6 into master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary information at top of Last Call is confusing
3 participants