feat(sprint-poker): Push task to GitLab #6427
Conversation
…rabolInc/parabol into feat/6088/gitlab-issues-functionality
| @@ -131,6 +137,8 @@ const TaskFooterIntegrateMenu = (props: Props) => { | |||
| mutationProps={mutationProps} | |||
| teamId={teamId} | |||
| label={label} | |||
| gitlabRef={viewerIntegrations.gitlab} | |||
There was a problem hiding this comment.
Maybe also consider passing cloudProvider which should be generic across different integrations
|
@mattkrick or @Dschoordsch it'd be great to get a Maintainer Review on this one when you get the chance. Once this PR and #6398 are merged, we can launch v1 of the GitLab integration. I mentioned to @lorena-cure that I estimate that v1 will be ready in prod by the next ship on Wednesday. |
There was a problem hiding this comment.
Works for the owner of the integration. Doesn't work for non-integrated users:
- Gerrit has GitLab integration and creates a task "Push me"
- Tina is a teammate of Gerrit and tries to push the task "Push me" on behalf of Gerrit
For Jira/Git this will push the task using Gerrit's credentials and add a comment that it was pushed by Tina on his behalf. With this PR it shows a server error
error: '{"data":{"createTaskIntegration":null},"errors":[{"message":"Method not implemented yet.","locations":[{"line":6,"column":3}],"path":["createTaskIntegration"]}]}'
I'm fine moving this into a separate issue/PR.
|
Nice catch! I've implemented the I'll move this issue into the Stuck column until the base branch is merged |
Fix #6365 and fix #6428
This PR refactors the GitLab queries and mutations to use the
TaskIntegrationManagerFactorypattern that Igor created. Using this class, I've also implemented pushing a Parabol task card to a GitLab project.