fix: server health check comment out #9001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <[email protected]>
Dschoordsch
approved these changes
Oct 21, 2023
|
Setting the token null fixes the immediate problem, but we still show the client an error. Once they reload they can log in again, so it is an improvement, but it's not enough to do a secret update |
|
true! the right way to do it is to watch for 401 coming from the websocket/sse request. i'll have to PR trebuchet to do that |
mattkrick
added a commit
that referenced
this pull request
Oct 23, 2023
* chore(ci): package name removed from the PR title * chore(ci): Release please now will not include the component name on the tags. Tag release will be added to the Release Please PRs * fix: remove health check (#9001) Signed-off-by: Matt Krick <[email protected]> * fix: re-add serverHealthChecker (#9024) Signed-off-by: Matt Krick <[email protected]> --------- Signed-off-by: Matt Krick <[email protected]> Co-authored-by: Rafael Romero <[email protected]>
mattkrick
added a commit
that referenced
this pull request
Oct 23, 2023
* chore(ci): package name removed from the PR title * chore(ci): Release please now will not include the component name on the tags. Tag release will be added to the Release Please PRs * fix: remove health check (#9001) Signed-off-by: Matt Krick <[email protected]> * fix: re-add serverHealthChecker (#9024) Signed-off-by: Matt Krick <[email protected]> * fix: ignore git tags when building Signed-off-by: Matt Krick <[email protected]> * fix: bash typo Signed-off-by: Matt Krick <[email protected]> --------- Signed-off-by: Matt Krick <[email protected]> Co-authored-by: Rafael Romero <[email protected]>
mattkrick
added a commit
that referenced
this pull request
Oct 23, 2023
* chore(ci): package name removed from the PR title * chore(ci): Release please now will not include the component name on the tags. Tag release will be added to the Release Please PRs * fix: remove health check (#9001) Signed-off-by: Matt Krick <[email protected]> * fix: re-add serverHealthChecker (#9024) Signed-off-by: Matt Krick <[email protected]> * fix: no-docker-provenance Signed-off-by: Matt Krick <[email protected]> * dockerize Signed-off-by: Matt Krick <[email protected]> * dockerize: test manual build Signed-off-by: Matt Krick <[email protected]> * fix: debug build yml Signed-off-by: Matt Krick <[email protected]> * dockerize Signed-off-by: Matt Krick <[email protected]> * clean up build.yml Signed-off-by: Matt Krick <[email protected]> --------- Signed-off-by: Matt Krick <[email protected]> Co-authored-by: Rafael Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hotfixes to fix k8s