feat: Recurring GCal event dialog #9506
Conversation
Dschoordsch
force-pushed
the
feat/9406/recurringGCalEventDialog
branch
from
021de43 to
afc0311
Compare
There was a problem hiding this comment.
I really like that you've combined them into one modal. That makes a lot of sense.
The main thing that I think needs changing before shipping it is giving the user some confirmation state once they've selected the calendar invite or recurrence settings. At the moment, I think it's easy to think you've created a calendar/recurrence setting, create the meeting, and discover that it hasn't happened: https://www.loom.com/share/0a61393ad28e4e2bb5951bb5ec23c726
| @@ -299,6 +303,20 @@ const ActivityDetailsSidebar = (props: Props) => { | |||
| history.push(`/me/organizations/${selectedTeam.orgId}/billing`) | |||
| } | |||
|
|
|||
| const meetingNamePlaceholder = | |||
There was a problem hiding this comment.
+1 I think this should just be "Enter the name of your meeting" rather than the meeting type. As user could think the placeholder is the actual value of the text, whereas "Enter the name of your meeting" makes it clearer that they need to update the input in my opinion.
There was a problem hiding this comment.
They don't need to enter anything, we will default to the placeholder. Why forcing the extra step on them?
There was a problem hiding this comment.
Ah I thought it was a required input
| <Collapsible.Root | ||
| className='flex flex-col rounded border border-slate-500' | ||
| open={hasGcalEvent} | ||
| onOpenChange={onOpenGcalChange} |
There was a problem hiding this comment.
-1 after integrating with gcal, I think the Calendar Invite section should automatically open. After I integrated with GCal, it wasn't clear to me that I could edit the settings
|
I see. The 'x' actually removes the recurrence/gcal invite. As it's an accordion, the user might not expect that. I will play around with the wording a bit and see how it looks:
What's not clear to me yet is how to get rid of the invite again. I think there needs to be a more obvious button for this (probably a trash can) |
|
@nickoferrall I've updated the dialog to not mix expanding/contracting the accordion with enabling/disabling anymore. Let me know what you think |
|
I will fix the merge conflicts after the review is done to avoid additional changes in the changeset. |
Dschoordsch
force-pushed
the
feat/9406/recurringGCalEventDialog
branch
from
b551502 to
b8160a3
Compare
Description
Fixes #9406
Combine Gcal scheduling dialog with recurring retros
Demo
https://www.loom.com/share/160fc84e251e49f8a5d2bfd01381b959?sid=eddcf00d-239d-49e5-a15c-818cca6618c5
Testing scenarios
recurringRetrosfeature flag add recurrence and gcal event to a retroFinal checklist