Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make hasGCalError optional #9526

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Mar 12, 2024

Fixes: #8976

During testing I ran into "Cannot return null for non-nullable field hasGCalError" issues. This is not necessary because it's not a criitical field. Avoid these kind of mistakes by just making it optional.

Testing scenarios

  • restart a team prompt via processRecurrence

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

During testing I ran into "Cannot return null for non-nullable field
hasGCalError" issues. This is not necessary because it's not a criitical
field. Avoid these kind of mistakes by just making it optional.
@Dschoordsch Dschoordsch merged commit 9350b93 into master Mar 12, 2024
6 checks passed
@Dschoordsch Dschoordsch deleted the fix/makeHasGCalErrorOptional branch March 12, 2024 11:31
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot return null for non-nullable field StartTeamPromptSuccess.hasGcalError.
1 participant