Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't reuse another team members integrated task #9600

Merged

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Apr 4, 2024

If we reuse another team members integrated task, then we can end up in a situation where they're not on the team anymore and mess up the integration access.

Testing scenarios

  • create a team with 2 users: Stan and Lili
  • Lili starts Poker, adds Task ABC-1 from Jira and finishes the meeting
  • Stan removes Lili from the team
  • Stan starts a Poker meeting and also adds ABC-1
  • check DB that the new task for ABC-1 has the userId of Stan
    • something along the lines of these queries
      r.db('actionDevelopment').table('NewMeeting').get('vQvshNiFz2')
      r.db('actionDevelopment').table('Task').getAll('vQvsROWc6I', 'vQsYJeTEVa')
      

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

If we reuse another team members integrated task, then we can end up in
a situation where they're not on the team anymore and mess up the
integration access.
@Dschoordsch Dschoordsch requested a review from nickoferrall April 4, 2024 15:55
@Dschoordsch Dschoordsch merged commit 9794033 into master Apr 4, 2024
8 checks passed
@Dschoordsch Dschoordsch deleted the fix/avoidReusingIntegrationTasksFromOtherMembers branch April 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant