Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depending on npm-tests so geth isn't going to have a race condition. #344

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Depending on npm-tests so geth isn't going to have a race condition. #344

merged 2 commits into from
Oct 17, 2019

Conversation

Freydal
Copy link
Contributor

@Freydal Freydal commented Oct 17, 2019

Overview

Description

Testing instructions

Types of changes

  • Refactor/enhancement
  • Bug fix/behavior correction
  • New feature
  • Breaking change
  • Other, additional

Notes

Status

  • Prefix PR title with [WIP] if necessary (changes not yet made).
  • Add tests to cover changes as needed.
  • Update documentation/changelog as needed.
  • Verify all tests run correctly in CI and pass.
  • Ready for review/merge.

@Freydal Freydal requested a review from hrharder October 17, 2019 17:31
@Freydal Freydal merged commit dc85724 into master Oct 17, 2019
@Freydal Freydal deleted the fix/stopping-false-positiives branch October 17, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrharder hrharder hrharder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freydal @hrharder