Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-kosu: use a list type to store orders #354

Closed
wants to merge 3 commits into from
Closed

Conversation

qustavo
Copy link
Contributor

@qustavo qustavo commented Oct 29, 2019

This PR introduces a List (taken from cosmos-sdk code) type to store and retrieve the orders from the strore.

@qustavo qustavo requested a review from hrharder October 29, 2019 19:34
@qustavo qustavo added will-break-app-state This change will break the Application State WIP Work in Progress labels Oct 29, 2019
@qustavo
Copy link
Contributor Author

qustavo commented Oct 29, 2019

I was investigating why when validators nodes boot the CPU is stuck at 100% and I noticed that it might be related to the orders. Also while the full node is syncing, the CPU goes to 100%.
Using strace I attached to the process and saw that most of the syscalls were reading orders from the DB.

This PR tries to mitigate that issue

hrharder
hrharder previously approved these changes Oct 29, 2019
@qustavo
Copy link
Contributor Author

qustavo commented Oct 30, 2019

Moved to #356

@qustavo qustavo closed this Oct 30, 2019
@qustavo qustavo deleted the go-kosu/list-orders branch October 30, 2019 19:12
@qustavo qustavo restored the go-kosu/list-orders branch October 30, 2019 19:12
@hrharder hrharder deleted the go-kosu/list-orders branch October 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will-break-app-state This change will break the Application State WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants