-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux AArch64 wheel build support #154
Conversation
Thanks for the PR. I am willing to merge this as ARM64 is the next most used architecture after the existing wheels, and these are only built on releases which are pretty infrequent. There are a couple things needed:
|
be173d9
to
b283190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing with WARNING: Built wheel for ssh2-python is invalid: Metadata 1.2 mandates PEP 440 version, but '0.26.0-2-gb283190' is not
.
This seems a recent change, previously could install these, but in any case in order to confirm the build works can you please replace the ssh2/_version.py file with the following contents:
import json
version_json = '''
"0.99.0"''' # END VERSION_JSON
def get_versions():
return json.loads(version_json)
This file will also need reverting, along with the CI filters, once the build is confirmed to work correctly. It looks good other than the version thing.
The test failures look not relevant, probably from a CI environment change. Will take a look separately.
b283190
to
2fb6067
Compare
2fb6067
to
740eac2
Compare
Editing ssh2/_version.py(commit #2fb6067) isn't working. Please take a look at these logs: https://app.circleci.com/pipelines/github/odidev/ssh2-python/33/workflows/2094e331-5df8-4fa4-b7b6-7e3c4fcf11ef/jobs/120 To test this on tag creation, I released a tag and wheel build look to be working fine. Please take a look at these logs: https://app.circleci.com/pipelines/github/odidev/ssh2-python/36/workflows/3bdd6111-8dd9-4881-9750-477d69e29430/jobs/129 |
Thanks for making these changes. Looks good to me. Will take a look at the build failures separately to be able to merge this. |
@pkittenis, can you please let me know if you get a change to look into it? |
Not yet I'm afraid. When I get some time. |
Closed and reopened to trigger the build. |
Closes #153