Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing the windows build issue #264

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fixing the windows build issue #264

merged 3 commits into from
Jan 7, 2025

Conversation

cjlapao
Copy link
Collaborator

@cjlapao cjlapao commented Jan 7, 2025

Description

  • Fixed the issue with the windows build
  • Added a strategy to test all build targets during PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests that prove my fix is effective or that my feature works
  • I have updated the CHANGELOG.md file accordingly

@cjlapao
fixing the windows build issue
9cca609 
- Fixed the issue with the windows build
- Added a strategy to test all build targets during PR
@cjlapao cjlapao added this to the 0.9.12 milestone Jan 7, 2025
@cjlapao cjlapao merged commit 3e7beba into main Jan 7, 2025
14 checks passed
@cjlapao cjlapao deleted the cjlapao/cache-automation/fix-windows-build branch January 7, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevlasu alevlasu Awaiting requested review from alevlasu alevlasu is a code owner

@bineesh-n bineesh-n Awaiting requested review from bineesh-n bineesh-n is a code owner

@polonius polonius Awaiting requested review from polonius polonius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.12
Development

Successfully merging this pull request may close these issues.
1 participant
@cjlapao