Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controllers for log streaming #271

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix controllers for log streaming #271

merged 1 commit into from
Jan 10, 2025

Conversation

cjlapao
Copy link
Collaborator

@cjlapao cjlapao commented Jan 10, 2025

Description

  • added an error message if file logger is disabled
  • enabled file logger by default

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests that prove my fix is effective or that my feature works
  • I have updated the CHANGELOG.md file accordingly

@cjlapao
Fix controllers for log streaming
22a2fb4 
- added an error message if file logger is disabled
- enabled file logger by default
@cjlapao cjlapao added this to the 0.9.12 milestone Jan 10, 2025
@cjlapao cjlapao merged commit 5729dd9 into main Jan 10, 2025
20 checks passed
@cjlapao cjlapao deleted the cjlapao/log-stream/enable-file-log-by-default branch January 10, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevlasu alevlasu Awaiting requested review from alevlasu alevlasu is a code owner

@bineesh-n bineesh-n Awaiting requested review from bineesh-n bineesh-n is a code owner

@polonius polonius Awaiting requested review from polonius polonius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.12
Development

Successfully merging this pull request may close these issues.
1 participant
@cjlapao