Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/format code to conform to solidity guidelines. No changes in functionality. #59

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Update/format code to conform to solidity guidelines. No changes in functionality. #59

wants to merge 6 commits into from

Conversation

eccentricexit
Copy link

@eccentricexit eccentricexit commented Jun 29, 2018

This reformats code to conform to solidity style guidelines. Also makes public functions visibilities explicit, solving #24 .

No tests fail.

Summary

  • swap deprecated "constant" modifier in favour of "view";
  • 4 spaces indentation;
  • use double quotes instead of single quotes;
  • swap deprecated contract name function in favor of "constructor";
  • use exactly one space on each side of "=" in assignments;;
  • add "emit" keyword before event emissions;
  • make function visibility explicit.

@eccentricexit eccentricexit changed the title Fix visibility warnings Update/format code to conform to solidity guidelines. No changes in functionality. Jun 29, 2018
@ya7ya ya7ya requested a review from jellegerbrandy June 29, 2018 19:11
@jellegerbrandy
Copy link
Contributor

Many thanks, Matheus, this was much needed.
I get a compilation error locally, probably because I need to update the compiler. Can you please update package.json with the new versions?

@eccentricexit
Copy link
Author

I've updated truffle in the package.json. This might also solve #51

@jellegerbrandy
Copy link
Contributor

A few remarks:

I'll also merge this as is, but it would be nice to catch all the warnings :-)

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants