Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Maintenance: update devDependencies and peerDependencies, fix npm audits and make tests run #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jacklrs
Copy link

@jacklrs jacklrs commented May 10, 2021

There is raviger which make this pull request obsolete ...

Hi,
I had issues install this package in context of npm7 and packages depending on react 7.x .
Since I like to go further with this package (thx to this nice approach!) and I like to help try to update it instead of apply
possible workarounds with npm install flags (e.g via --legacy-peer-deps flat), here the changes:

  • Updated peerDependencies to be compatible with npm7 and packages depending on react 17.x
  • Corrected package version to mach current latest version (1.2.5)
  • Fixed all npm audit findings by updating all devDependencies
  • Fixed all tests to run successfully
  • added eslint as devDependency

Thx in advance for any feedback and potential merge!

@pramodkandel
Copy link

I really like hookrouter, and I had this problem recently with npm7 as well. Hopefully this patch gets merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants