Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Font Awesome Icons more flexible #30

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

EpicLPer
Copy link
Contributor

This change makes Font Awesome icons a bit more flexible, but moves the "fa" and "fab" etc. code to the customization yml. I had to make this change to my own theme customization as example cause I wasn't able to use the E-Mail symbol initially since "fab" is only ever used for brand icons, think this is simply a more flexible solution for this problem also for other icons.

@ParitoshBh
Copy link
Owner

Hey!

Thanks for contributing 😄

While this is a welcome change and I agree this is much more flexible that what we have right now. I am thinking about backward compatibility in the sense that would pushing this break any of existing installations.

I do plan to test it over this weekend. Will report my findings.

@ParitoshBh ParitoshBh self-requested a review August 12, 2022 03:28
@ParitoshBh ParitoshBh added the enhancement New feature or request label Aug 12, 2022
@EpicLPer
Copy link
Contributor Author

I'm not sure how easily this could be done, but you could do an "if" condition in he footer and base twig to check if it does have a "fab" or "fa" in front, and if it doesn't then just default back to "fab".
I'm by no means a Grav expert tho and only really gotten into it a week ago or so, and this was my very first experience tinkering with themes :)

@ParitoshBh
Copy link
Owner

Tested it against Grav version 1.7.11 and 1.7.35 (latest on at the time). Works just fine. I am not adding any logic around the removed fab, we'll mention the same in changelog and tag it as breaking change.

@ParitoshBh ParitoshBh merged commit 034c607 into ParitoshBh:master Aug 12, 2022
@EpicLPer EpicLPer deleted the patch-1 branch August 12, 2022 21:30
@ParitoshBh
Copy link
Owner

Pushed as part of version 0.1.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants