Remove authority selection from onboarding #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Erichsen <[email protected]>
|
Tested on emulators: pixel2 and nexus 4 |
tstirrat
approved these changes
Apr 24, 2020
tstirrat
added a commit
to alinelutz/covid-safe-paths
that referenced
this pull request
Apr 24, 2020
* develop: (29 commits) Italian language updates (Path-Check#626) Remove authority selection from onboarding (Path-Check#679) v1.0.0 (Path-Check#669) Hide unintented "What does this mean?" message (Path-Check#668) BUGFIX: Add authority wasn't immediate (Path-Check#667) Polish the EULA (Path-Check#666) Add in a 6 hour time period between notifications (Path-Check#665) Add an EULA to the onboarding process (Path-Check#638) change to rawcdn for the versions.yaml file (Path-Check#662) Change naming in yaml, change yaml link (Path-Check#661) Add version check service (Path-Check#653) Add healthcare selection to onboarding flow (Path-Check#657) Add yaml file for version checking (Path-Check#658) Fix languages specific for history page (Path-Check#628) Lokalise: Translations update (ht) (Path-Check#655) Temporarily filter out extra languages in release mode (Path-Check#654) Suggest screenshots and fixed issues in PR template (Path-Check#637) Fix settings locale override storage (Path-Check#649) Disable google import on release builds (Path-Check#651) Revert "Fix missing settings icon on iOS 12.0.x (Path-Check#643)" (Path-Check#650) ...
tstirrat
added a commit
that referenced
this pull request
Apr 24, 2020
* develop: (24 commits) Translation to Brazilian Portuguese (#614) Italian language updates (#626) Remove authority selection from onboarding (#679) v1.0.0 (#669) Hide unintented "What does this mean?" message (#668) BUGFIX: Add authority wasn't immediate (#667) Polish the EULA (#666) Add in a 6 hour time period between notifications (#665) Add an EULA to the onboarding process (#638) change to rawcdn for the versions.yaml file (#662) Change naming in yaml, change yaml link (#661) Add version check service (#653) Add healthcare selection to onboarding flow (#657) Add yaml file for version checking (#658) Fix languages specific for history page (#628) Lokalise: Translations update (ht) (#655) Temporarily filter out extra languages in release mode (#654) Suggest screenshots and fixed issues in PR template (#637) Fix settings locale override storage (#649) Disable google import on release builds (#651) ...
tstirrat
added a commit
that referenced
this pull request
Apr 24, 2020
* develop: (24 commits) Translation to Brazilian Portuguese (#614) Italian language updates (#626) Remove authority selection from onboarding (#679) v1.0.0 (#669) Hide unintented "What does this mean?" message (#668) BUGFIX: Add authority wasn't immediate (#667) Polish the EULA (#666) Add in a 6 hour time period between notifications (#665) Add an EULA to the onboarding process (#638) change to rawcdn for the versions.yaml file (#662) Change naming in yaml, change yaml link (#661) Add version check service (#653) Add healthcare selection to onboarding flow (#657) Add yaml file for version checking (#658) Fix languages specific for history page (#628) Lokalise: Translations update (ht) (#655) Temporarily filter out extra languages in release mode (#654) Suggest screenshots and fixed issues in PR template (#637) Fix settings locale override storage (#649) Disable google import on release builds (#651) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Erichsen [email protected]
Description
Removes the Healthcare Authority selection from onboarding - requested by our testers after finding the current flow to be confusing.
This is breaking the e2e tests but with the impending authority auto subscription work I think it's okay for now.
Linked issues:
#675
Screenshots:
How to test
Go through onboarding in both iOS and Android and confirm there is not Healthcare step and that the process in general still works correctly.