Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev README #705

Merged
merged 2 commits into from
May 1, 2020
Merged

Update dev README #705

merged 2 commits into from
May 1, 2020

Conversation

Patrick-Erichsen
Copy link
Contributor

Signed-off-by: Patrick Erichsen [email protected]

Description

Updates the README with instructions for testing, and updates a bit of formatting.

@Patrick-Erichsen
Copy link
Contributor Author

@tstirrat @kenpugsley @efalkner would appreciate any feedback on these updates. I added info on running the e2e tests but also tried to include a bit of basic debugging things that I wasn't aware of as a new RN dev.

Not sure how relevant some of that is though so feel free to strip anything out.

alpita-masurkar
alpita-masurkar reviewed Apr 28, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
alpita-masurkar
alpita-masurkar reviewed Apr 28, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
tstirrat
tstirrat suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@tstirrat tstirrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
reset_react.sh Show resolved Hide resolved
@Patrick-Erichsen
Update dev README
32dac40 
Signed-off-by: Patrick Erichsen <[email protected]>
tstirrat
tstirrat previously approved these changes Apr 29, 2020
View reviewed changes
efalkner
efalkner reviewed Apr 29, 2020
View reviewed changes
README.md

Read the [contribution guidelines](CONTRIBUTING.md).
Generating a release build is an optional step in the development process.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And requires an 🍎 developer id to be provisioned (currently) though soon that will not be the case!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So following those steps for Android, I was able to build with a self signer cert.

For the developer ID stuff on iOS, is that going to be soon enough to make it not worth mentioning?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"release build" vs "development build" is kind of misleading in this context, I guess.

There are really two different environments to manage as a RN developer - Javascript release and native release. Basically, my thought is we should clarify the difference - "release" sounds like it's ready for the app store, when it's really an unsigned artifact talking to a metro bundler. That being said, it's not worth splitting hairs here. We could eventually add some links in to android and apple docs on the different types of builds available :)

efalkner
efalkner reviewed Apr 29, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
efalkner
efalkner reviewed Apr 29, 2020
View reviewed changes
README.md Show resolved Hide resolved
efalkner
efalkner reviewed Apr 29, 2020
View reviewed changes
README.md Show resolved Hide resolved
efalkner
efalkner reviewed Apr 29, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Patrick-Erichsen
Incorporate feedback
27e1e5e 
Signed-off-by: Patrick Erichsen <[email protected]>
tstirrat
tstirrat approved these changes Apr 30, 2020
View reviewed changes
README.md Show resolved Hide resolved
@tstirrat tstirrat merged commit 9ecabc2 into Path-Check:develop May 1, 2020
tstirrat added a commit to eyganeshv/covid-safe-paths that referenced this pull request May 1, 2020
@tstirrat
Merge branch 'develop' into pr/eyganeshv/521
c61f562 
* develop:
  Update dev README (Path-Check#705)
  Better error logging in Google import (Path-Check#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724)
  Translation refresh (Path-Check#708)
  updated issue template (Path-Check#729)
tstirrat added a commit that referenced this pull request May 2, 2020
@tstirrat
Merge branch 'develop' into ts-icon-button
0a217c8 
* develop:
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
tstirrat added a commit that referenced this pull request May 2, 2020
@tstirrat
Merge branch 'develop' into ts-theme-button
4b91a3e 
* develop: (60 commits)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
  Remove react-native-maps (#695)
  ...
tstirrat added a commit that referenced this pull request May 3, 2020
@tstirrat
Merge branch 'develop' into ts-feature-flags
a14deaa 
* develop:
  Add language contribution info to contributing guide (#754)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
@Patrick-Erichsen Patrick-Erichsen deleted the readme-update branch May 3, 2020 22:49
tstirrat added a commit that referenced this pull request May 4, 2020
@tstirrat
Merge branch 'develop' into ts-eula-i18n
6f8fbc2 
* develop:
  Build time feature flags (Phase 1) (#694)
  Extract theme aware <IconButton /> component (#756)
  Latest i18n pull (#755)
  Add language contribution info to contributing guide (#754)
  Recommend PR best practices in PR template (#750)
  Add eslint react-hooks checks (#751)
  iOS: Added local notification in terminate function. (#521)
  Update dev README (#705)
  Better error logging in Google import (#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (#724)
aputinski pushed a commit to safe-paths-contrib/covid-safe-paths that referenced this pull request May 6, 2020
Merge remote-tracking branch 'official/develop' into survey
734ad7a 
* official/develop: (110 commits)
  Consolidate to a single theme aware Button component (Path-Check#767)
  Fixed incorrect pull command. (Path-Check#769)
  Update README, etc for tripleblind -> Path-Check (Path-Check#768)
  HTML EULA translation workflow (Path-Check#710)
  Allowing setup on macOS/Darwin for Android only. (Path-Check#766)
  Add Danish to the list of languages. (Path-Check#765)
  Fixed the aspect ration on the icon and add links (Path-Check#763)
  Build time feature flags (Phase 1) (Path-Check#694)
  Extract theme aware <IconButton /> component (Path-Check#756)
  Latest i18n pull (Path-Check#755)
  Add language contribution info to contributing guide (Path-Check#754)
  Recommend PR best practices in PR template (Path-Check#750)
  Add eslint react-hooks checks (Path-Check#751)
  iOS: Added local notification in terminate function. (Path-Check#521)
  Update dev README (Path-Check#705)
  Better error logging in Google import (Path-Check#703)
  Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724)
  Translation refresh (Path-Check#708)
  updated issue template (Path-Check#729)
  Set up location after skiping the steps (Path-Check#721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpita-masurkar alpita-masurkar alpita-masurkar left review comments

@efalkner efalkner efalkner left review comments

@tstirrat tstirrat tstirrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Patrick-Erichsen @tstirrat @efalkner @alpita-masurkar