Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default image path for 1.0.0 #229

Closed
wants to merge 1 commit into from
Closed

Update default image path for 1.0.0 #229

wants to merge 1 commit into from

Conversation

jacobmischka
Copy link

Removed rc3 and added trailing /

Also build, looks like that hadn't been done prior to last commit

Without this commit, cdnjs image links were failing as they kept pointing to nonexistent urls like .../imagesmarker-icon.png when using leaflet 1.0.0.

I understand if you'd like to fold this change into the rest of the upcoming 1.0.0 changes, but I needed it now and did it already so figured I might as well make a PR.

Removed rc3 and added trailing /

Also build, looks like that hadn't been done prior to last commit
@Dahlgren Dahlgren mentioned this pull request Sep 28, 2016
@PaulLeCam
Copy link
Owner

Hi,
Thanks for this PR but it should no longer be necessary to set the default icon path with Leaflet v1.0.0.

@PaulLeCam PaulLeCam closed this Sep 28, 2016
@jacobmischka jacobmischka deleted the next branch September 28, 2016 14:42
@baptwaels
Copy link

Hi,

it should no longer be necessary to set the default icon path with Leaflet v1.0.0

I use :

  • "leaflet": "^1.0.1"
  • "react-leaflet": "^1.0.0-rc.2"

but I still get this error :

.../imagesmarker-icon.png Failed to load resource: 404 (Not Found)
.../imagesmarker-icon.png Failed to load resource: 404 (Not Found)

Why do I still get it ?

@jacobmischka
Copy link
Author

jacobmischka commented Oct 24, 2016

Currently the path is set with some weird CSS magic in leaflet 1.0. If you're using a module bundler like webpack it probably doesn't support it: webpack-contrib/css-loader#322

Edit: Ah nevermind, looks like this was fixed in leaflet 1.0.1.

@baptwaels
Copy link

Yes, It tries to load the image from :

http://cdnjs.cloudflare.com/ajax/libs/leaflet/0.7.7/imagesmarker-icon.png 404 (Not Found)

But the image doesn't exist

@jacobmischka
Copy link
Author

jacobmischka commented Oct 24, 2016

That line was removed from react-leaflet in 1.0.0-rc.1: b0e95ff#diff-1fdf421c05c1140f6d71444ea2b27638L34

Because the version number you see is still 0.7.7 it looks like you're using a version of react-leaflet older than 1.0.0-rc.2.

@baptwaels
Copy link

baptwaels commented Oct 25, 2016

Oh great ! I was also using react-leaflet-draw. This package has installed react-leaflet 0.12.1 as dependencies.

Everything works great now.
Thanks a lot for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants