fix: initial guess explanation correction #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! I think what I had in mind when I wrote that comment is that the power of two itself if squared again, but that is obviously wrong. As per the next comment in the
The result couldn't have been maximum 2^127 if the initial guess was the least power of two greater than |
|
you reversed the key change in this PR in this commit heh, was that intentional? |
|
LOL 😂 Did it twice. I meant to write |
|
haha all good just wanted to make sure we were on the same page! merry christmas :) |
|
You too man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i believe this explanation is incorrect, see an explanation of Newton's Method (which the babylonian method uses) in Hacker's Delight for details