fix: inconsistency in the sqrt function #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97.
The
sqrt
function using newton methods with a first guess that is the most significant bit of thesqrt
or x. This is done using an algorithm that is similar tomostSignificantBit
, but that increase the result by the half of whatmostSignificantBit
does.While
mostSignificantBit
is correct,sqrt
uses 0x8 instead of 0x4 for2**2
Note: a cleaner, but slightly more expensive, version of the code could do