WIP

Paxxi · Aug 7, 2017 · 0b98780 · 0b98780
1 parent 7ef44ae
commit 0b98780
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/System.Net.Primitives/src/System/Net/IPAddress.cs b/src/System.Net.Primitives/src/System/Net/IPAddress.cs
@@ -263,12 +263,29 @@ internal IPAddress(int newAddress)
         /// </devdoc>
         public static bool TryParse(string ipString, out IPAddress address)
         {
+            if (ipString == null)
+            {
+                address = null;
+                return false;
+            }
+
+            var tempBuffer = ipString.ToCharArray();
             address = IPAddressParser.Parse(ipString, true);
             return (address != null);
         }
 
+        public static bool TryParse(ReadOnlySpan<char> ipSpan, out IPAddress address)
+        {
+            address = IPAddressParser.Parse(ipSpan, true);
+            return (address != null);
+        }
+
         public static IPAddress Parse(string ipString)
         {
+            if (ipString == null)
+                throw new ArgumentNullException(nameof(ipString));
+
+            var tempBuffer = ipString.ToCharArray();
             return IPAddressParser.Parse(ipString, false);
         }
 

diff --git a/src/System.Net.Primitives/src/System/Net/IPAddressParser.cs b/src/System.Net.Primitives/src/System/Net/IPAddressParser.cs
@@ -11,6 +11,11 @@ namespace System.Net
 {
     internal class IPAddressParser
     {
+        internal static unsafe IPAddress Parse(ReadOnlySpan<char> ipSpan, bool tryParse)
+        {
+            return Parse(ipSpan.ToString(), tryParse);
+        }
+
         internal static unsafe IPAddress Parse(string ipString, bool tryParse)
         {
             if (ipString == null)