Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2369] RunnerTest fail on Windows due to network startup timing issue #1005

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

ekellstrand
Copy link
Contributor

@ekellstrand ekellstrand commented Feb 27, 2019

PR description

PAN-2369 RunnerTest fail on Windows due to network startup timing issue

  • Forces RunnerTest to wait for the P2PNetwork to start and actually configure it's ports before asking for them.
  • Re-Enables RunnerTest.fullSyncFromGenesis()
  • Re-Enables RunnerTest.fastSyncFromGenesis()

Fixed Issue(s)

PAN-2369

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd be tempted to wait something more like 20 seconds because I'm always amazed at how slow things can be when running tests...

@ekellstrand
Copy link
Contributor Author

In this case, slow is fine. The timing issue only seems to happen on fast boxes with lots of cores. And in my case, it was reliably only a couple of ms required. However, I'm not opposed to 20 sec, to that'll be coming right up.

@ekellstrand ekellstrand merged commit a34d961 into PegaSysEng:master Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants