This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2372] Consider a world state download stalled after 100 requests with no progress #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…made 100 requests without getting any new data back.
… outstanding requests, not maximum nubmer of requests until we consider the download stalled.
mbaxter
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Modify the world state downloader to consider a download stalled when 100 requests have failed to return any requested data rather than when a specific node has failed to download 25 times. The previous approach could lead to considering a download stalled if our peers returned partial responses to our requests (e.g. limiting the number of nodes they return per request) even if the data was still available in the network.