This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2302] Resume world state download from existing queue #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move trie traversal logic out of tests.
ajsutton
approved these changes
Feb 28, 2019
| assertThat(result.size()).isEqualTo(1); | ||
| assertThat(result.get(0).getValue()).contains(BytesValue.of(1)); | ||
| // TODO: fix path representation | ||
| // assertThat(result.get(0).getPath()).isEqualTo(BytesValue.fromHexString("0x100000")); |
There was a problem hiding this comment.
Does this need looking at still?
There was a problem hiding this comment.
Yeah - I'll make a ticket for this. It's an existing issue.
There was a problem hiding this comment.
Looks like this isn't actually a "bug" - the path value is just handled in an idiosyncratic way. Updated the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR updates
RocksDbTaskQueueso that on construction, any existing data on disk will be read and accounted for. Previously, the queue would always be empty on initialization. Now that the queue can be resumed, theWorldStateDownloadermodifies its behavior when started with a non-empty queue. Rather than requesting the root node when the download begins, this node will only be requested when all other nodes have been processed. This prevents us from queueing the root node multiple times each time the download is resumed.Additionally, some trie node utility methods were made more generic and moved from the tests into
TrieNodeDecoder, which lead to the deduplication of some logic inTrieNodeDataRequest.