Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Trim default metrics #1086

Merged
merged 4 commits into from
Mar 12, 2019
Merged

Trim default metrics #1086

merged 4 commits into from
Mar 12, 2019

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Mar 12, 2019

PR description

Testing has shown that RocksDB and BigQueue metrics has a negative
impact on performance under load. Disable them by default.

@shemnon
Trim default metrics
d60273e 
Testing has shown that RocksDB and BigQueue metrics has a negative
impact on performance under load.  Disable them by default.
ajsutton
ajsutton approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems that our timers are quite expensive. I wonder if we should see if there's a sensible way to switch back to histograms which (at least in theory) can be created quite cheaply.

@shemnon
Copy link
Contributor Author

shemnon commented Mar 12, 2019

opened histogram spike as PAN-2440

@shemnon shemnon merged commit 628bc6c into PegaSysEng:master Mar 12, 2019
@shemnon shemnon deleted the metrics branch March 12, 2019 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @ajsutton