This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Reduce number of seen blocks and transactions Pantheon tracks #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Pantheon tracks hashes of transactions and blocks that we know other peers have seen to avoid sending them data they already have. These numbers were arbitrarily set to 30,000 which consumes a significant amount of memory. It takes hours for these limits to be reached which is much longer than the replay protection is actually needed.
Reduce to 300 max tracked blocks and 10,000 max tracked transactions. These are still fairly arbitrary limits but still take more than an hour to reach so should be sufficient.