This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Pipeline Improvements #1117
Merged
Pipeline Improvements #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormal pipe and creates batching on the fly. Avoids needing an extra thread and synchronization overhead to create batches.
…. Avoid exposing createPipe.
mbaxter
approved these changes
Mar 18, 2019
|
|
||
| @Test | ||
| public void shouldAddAtMostOneItemWhenDraining() { | ||
| // Collecting a batch of batches is pretty silly so only ever drain one batch at a time. |
There was a problem hiding this comment.
For the record, nothing actually ever calls this but it seems better to give it a vaguely sane implementation than to throw an exception and not implement the underlying interface properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When creating batches as part of a pipeline, instead of having a dedicated thread that creates the batches, do it inline via a new
BatchingReadPipewhich wraps a normalReadPipe.Also improve the metrics we capture for pipelines so we capture number of tasks added and removed from each pipeline making it possible to calculate how many tasks are in each pipe.