Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

PAN-2434: Updated local config permissioning flags #1118

Merged
merged 11 commits into from
Mar 19, 2019

Conversation

lucassaldanha
Copy link
Contributor

PR description

  • Changed --permissions-nodes-enabled to --permissions-nodes-config-file-enabled
  • Changed --permissions-accounts-enabled to --permissions-accounts-config-file-enabled
  • Removed --permissions-config-file
  • Created --permissions-nodes-config-file to configure the node permissioning config file
  • Created --permissions-accounts-config-file to configure the account permissioning config file

Obs. --permissions-nodes-config-file and --permissions-accounts-config-file can be set to the same file if desired.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

return permissioningConfiguration;
}

private static TomlParseResult readToml(final String filepath) throws Exception {
TomlParseResult nodePermissioningToml;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method is used for both node and account permissioning - can take 'node' out of variable name

verify(mockRunnerBuilder).build();

assertThat(commandErrorOutput.toString()).isEmpty();
assertThat(commandOutput.toString()).isEmpty();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method name says 'MustError' but it doesn't error

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit 3fffd60 into PegaSysEng:master Mar 19, 2019
@lucassaldanha lucassaldanha deleted the PAN-2434 branch March 19, 2019 01:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants