This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2363] Fix tcp port handling #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Most peers discovered on the network only define a single UDP port and have no explicitly defined TCP port. I experimentally confirmed that at least some of these peers are listening on the TCP port matching the advertised UDP port. This PR modifies
NettyP2PNetworkto attempt reaching out to all peers even if no TCP port is defined. Additionally there's some minor cleanup for some variable and function names I came across that were inaccurate.