This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2403] Periodically connect to peers from table #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
approved these changes
Mar 26, 2019
| .filter(peer -> peer.getStatus() == PeerDiscoveryStatus.BONDED) | ||
| .filter(peer -> !isConnected(peer) && !isConnecting(peer)) | ||
| .collect(Collectors.toList()); | ||
| Collections.shuffle(peers); |
There was a problem hiding this comment.
Paranoia: should we use Collections.shuffle(List<?>, Random) with a secure random?
ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/netty/NettyP2PNetwork.java
Outdated
Show resolved
Hide resolved
| return controller | ||
| .map(PeerDiscoveryController::getPeers) | ||
| .map(Collections::unmodifiableCollection) | ||
| .orElse(Collections.emptyList()); |
There was a problem hiding this comment.
Eliminating temporary collections. Nice!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR builds on #903. The periodic connection logic has been updated to be more aggressive and tests have been added. Additionally, executor logic has been moved from
NetworkRunnerintoNettyP2PNetworkallowing theP2PNetworkinterface to be simplified.