This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2503] permission provider that allows bootnodes if you have no other connections #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m Please enter the commit message for your changes. Lines starting
…ther_permissioned_peers
Errorific
deleted the
feature/PAN-2503.connect_bootnodes_if_no_other_permissioned_peers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have reached sync and have no allowed connections we need to explicitly allow the bootnodes as our only suspected safe nodes. Once we have connections outside of the bootnodes we can return to dogmatically obeying the permissioning rules as we have a pathway into the network again.