This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Feature/pie 1502 ewp options cli #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502
shemnon
reviewed
Apr 9, 2019
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
.../eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/EthereumWireProtocolConfiguration.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
| @@ -1100,6 +1097,114 @@ public void parsesInvalidFastSyncMinPeersOptionWrongFormatShouldFail() { | |||
| .contains("Invalid value for option '--fast-sync-min-peers': 'ten' is not an int"); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
We don't have a testing pattern yet for validating these unstable/hidden options, so this is an opportunity to feel it out. It doesn't feel like they should be in PantheonCommandTest but each mixin class should have its own. Where that class lives is I'm not sure about. We could do it in the module the builder live in, or we could do it in this module.
…nd.java Co-Authored-By: abdelhamidbakhta <[email protected]>
…nd.java Co-Authored-By: abdelhamidbakhta <[email protected]>
…nd.java Co-Authored-By: abdelhamidbakhta <[email protected]>
…nd.java Co-Authored-By: abdelhamidbakhta <[email protected]>
…/abdelhamidbakhta/pantheon into feature/pie-1502-ewp-options-cli
shemnon
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Out of scope for this PR, but I think we should investigate Guava's AutoValue (https://github.com/google/auto/blob/master/value/userguide/builders.md) for builders. Possibly compare it to Lombok, the main difference being AutoValue doesn't directly interface with the compiler and uses code generation instead.
| private PositiveNumber maxGetNodeData = | ||
| PositiveNumber.fromInt(EthereumWireProtocolConfiguration.DEFAULT_MAX_GET_NODE_DATA); | ||
|
|
||
| public Builder maxGetBlockHeaders(final PositiveNumber maxGetBlockHeaders) { |
There was a problem hiding this comment.
Could we change the method to just int, and then set the value to a PositiveNumber? That reduces the friction for API consumers while preserving the error checking.
mbaxter
reviewed
Apr 10, 2019
| @@ -156,7 +156,11 @@ private CliquePantheonController( | |||
| syncConfig.downloaderParallelism(), | |||
| syncConfig.transactionsParallelism(), | |||
| syncConfig.computationParallelism(), | |||
| metricsSystem); | |||
| metricsSystem, | |||
| syncConfig.getEthereumWireProtocolConfiguration().getMaxGetBlockHeaders(), | |||
There was a problem hiding this comment.
Hey @abdelhamidbakhta - Just seeing this. Can we update 2 things here:
- Remove
EthProtocolConfigurationfromSyncConfiguration - Just pass a single
EthProtocolConfigurationto the protocol manager rather than extracting out each option and passing it individually to the constructor
AbdelStark
added a commit
to AbdelStark/pantheon
that referenced
this pull request
Apr 10, 2019
AbdelStark
added a commit
that referenced
this pull request
Apr 10, 2019
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java * fix PR 1246 discussion #1246 (comment)
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java * fix PR 1246 discussion PegaSysEng#1246 (comment)
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java * fix PR 1246 discussion PegaSysEng#1246 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Expose Ethereum Wire Protocol request limits as hidden CLI options.
Acceptance Criteria
The following options are exposed as hidden CLI options
Fixed Issue(s)
fixes PIE-1502