This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[MINOR] migrate TransactionPool (& affiliated test) from 'core' to 'eth' #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
reviewed
Apr 10, 2019
| @@ -96,7 +96,7 @@ public boolean addRemoteTransaction(final Transaction transaction) { | |||
| return addTransaction; | |||
| } | |||
|
|
|||
| boolean addLocalTransaction(final Transaction transaction) { | |||
| public boolean addLocalTransaction(final Transaction transaction) { | |||
There was a problem hiding this comment.
You should move all of the TransactionPool related classes to eth. I believe that includes: TransactionPool, PendingTransactions, PendingTransactionListener, PendingTransactionDroppedListener.
There was a problem hiding this comment.
Yeah -- I was initially wondering about whether or not to do that -- I've updated the branch accordingly
smatthewenglish
force-pushed
the
boris
branch
4 times, most recently
from
9a01b71 to
3e6a1e9
Compare
shemnon
reviewed
Apr 10, 2019
ethereum/eth/build.gradle
Outdated
| @@ -55,4 +55,7 @@ dependencies { | |||
| testImplementation 'org.mockito:mockito-core' | |||
|
|
|||
| jmhImplementation project(path: ':ethereum:core', configuration: 'testSupportArtifacts') | |||
|
|
|||
| testImplementation project(path: ':config', configuration: 'testSupportArtifacts') | |||
There was a problem hiding this comment.
This like should be alphabetized with the rest of the testImplementation dependenceies. Between line 45 and 46
There was a problem hiding this comment.
Nice catch -- thank you.
shemnon
approved these changes
Apr 11, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Necessary pre-condition of using
SyncStateinTransactionPoolas a filtering mechanism.The gotcha was adding these lines:
to
ethereum/eth/build.gradle, sinceTransactionPoolTesthasExecutionContextTestFixturewhich requiresGenesisConfigFile, or anyway one of those files intech.pegasys.pantheon.config.Fixed Issue(s)