This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2499] debug trace transaction #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debug-trace-transaction
Returns a JSON RPC error instead of failing due to NPE.
…debug-trace-transaction
…debug-trace-transaction
…debug-trace-transaction
…debug-trace-transaction
Implement reason string on revert operation as in the following EIP : https://github.com/ethereum/EIPs/blob/master/EIPS/eip-140.md
AbdelStark
added
api
shemnon
reviewed
Apr 11, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/debug/TraceFrame.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/vm/MessageFrame.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/vm/operations/RevertOperation.java
Show resolved
Hide resolved
mbaxter
reviewed
Apr 11, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/vm/MessageFrame.java
Outdated
Show resolved
Hide resolved
mbaxter
reviewed
Apr 11, 2019
...main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/DebugTraceTransaction.java
Outdated
Show resolved
Hide resolved
mbaxter
reviewed
Apr 11, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/debug/TraceFrame.java
Outdated
Show resolved
Hide resolved
mbaxter
reviewed
Apr 11, 2019
.../java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/DebugTraceTransactionTest.java
Show resolved
Hide resolved
shemnon
reviewed
Apr 11, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/vm/MessageFrame.java
Outdated
Show resolved
Hide resolved
shemnon
approved these changes
Apr 11, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
* move subclass * Update Transaction.java * fix 500 error on tx not found Returns a JSON RPC error instead of failing due to NPE. * Handle reason on revert operation Implement reason string on revert operation as in the following EIP : https://github.com/ethereum/EIPs/blob/master/EIPS/eip-140.md * Update MessageFrame.java * Update RevertOperationTest.java * fix PR discussion * fix PR * Update DebugTraceTransaction.java
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
* move subclass * Update Transaction.java * fix 500 error on tx not found Returns a JSON RPC error instead of failing due to NPE. * Handle reason on revert operation Implement reason string on revert operation as in the following EIP : https://github.com/ethereum/EIPs/blob/master/EIPS/eip-140.md * Update MessageFrame.java * Update RevertOperationTest.java * fix PR discussion * fix PR * Update DebugTraceTransaction.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The
REVERTprovides the ability to return a reason string .We should get this reason when calling
debug_traceTransactionFixed Issue(s)
fixes #PAN-2499