This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
PAN-2404 - Make PeerDiscovertAgentTest less flakey. #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of deep issues sometimes we get duplicate Peers that differ in small ways. Tweak the test to verify we get all of the peers we are expecting and to be tolerant of quasi-duplicate peers.
mbaxter
approved these changes
Apr 11, 2019
mbaxter
reviewed
Apr 11, 2019
| @@ -73,7 +73,7 @@ public void neighborsPacketLimited() { | |||
|
|
|||
| // Start another peer pointing to those 20 agents. | |||
| final MockPeerDiscoveryAgent agent = helper.startDiscoveryAgent(otherPeers); | |||
| assertThat(agent.getPeers()).hasSize(20); | |||
| assertThat(agent.getPeers()).contains(otherPeers.toArray(new DiscoveryPeer[20])); | |||
There was a problem hiding this comment.
Might be good to add a comment here related to this change.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
Because of deep issues sometimes we get duplicate Peers that differ in small ways. Tweak the test to verify we get all of the peers we are expecting and to be tolerant of quasi-duplicate peers.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
Because of deep issues sometimes we get duplicate Peers that differ in small ways. Tweak the test to verify we get all of the peers we are expecting and to be tolerant of quasi-duplicate peers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Because of deep issues sometimes we get duplicate Peers that differ
in small ways. Tweak the test to verify we get all of the peers
we are expecting and to be tolerant of quasi-duplicate peers.
Fixed Issue(s)
PAN-2404