This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
PAN-2580 - missing p2p info when queried live #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out we don't have the p2p host and port at RPC initialization. To fix this change to query hosts and ports at method invocaiton time instead of whent he constructor is called. (cherry picked from commit 105dc5b)
macfarla
approved these changes
Apr 26, 2019
|
It has unit tests, but it's the integration that broke. Should I add new tests that validate this first? |
|
|
PAN-2589 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
It turns out we don't have the p2p host and port at RPC initialization.
To fix this change to query hosts and ports at method invocaiton time
instead of whent he constructor is called.
(cherry picked from commit 105dc5b, #1310)
Fixed Issue(s)
PAN-2580