This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Handle the pipeline being aborted while finalizing an async operation #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Apr 30, 2019
| inputPipe.abort(); | ||
| return false; | ||
| }); | ||
| inputPipe.close(); |
There was a problem hiding this comment.
Why do you need to close the inputPipe here?
There was a problem hiding this comment.
Because otherwise the processor won't enter the finalisation stage, it will wait forever for the next input.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When an async processing stage of a pipeline has started the async process for all inputs it enters finalisation mode where it waits for the outstanding tasks to complete. If Pantheon is shutdown while this finalisation is in progress it may delay shutdown because it doesn't check for the abort signal.
This changes the finalisation process so that when the thread is interrupted (or a task completes) it checks if the input pipe has been aborted and aborts finalisation to ensure we get a clean shutdown.