This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2652] RefactorPrivacyTests #1382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ekellstrand
commented
May 1, 2019
ekellstrand
commented
- Generate Account and Contract Hex instead of relying on literals
- Started conversion to a model that can generate keys & config, and support many nodes
- Generate Account and Contract Hex instead of relying on literals - Started conversion to a model that can generate keys & config, and support many nodes
iikirilov
reviewed
May 2, 2019
| node2.execute(privateTransactions.createPrivateRawTransaction(storeValueFromNode2)); | ||
|
|
||
| privateTransactionVerifier.validEventReturned("1000").verify(node1, transactionHash); | ||
| public PrivacyNode node(final int i) { |
There was a problem hiding this comment.
Helper methods can go in base class.
| /** Verify that each Orion node has connected to every other Orion */ | ||
| public void verifyAllOrionNetworkConnections() { | ||
| for (int i = 0; i < nodes.size(); i++) { | ||
| for (int j = i; j < nodes.size(); j++) { |
There was a problem hiding this comment.
int j = i + 1
you do not need to test connectivity between node 0 and node 0...
|
replaced by #1483 |
|
Closing as this is superseded by another PR that includes this and some other test enhancements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.