This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2624] Start listening for p2p connections after start() is invoked #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
commented
May 8, 2019
|
|
||
| /** Start listening for incoming connections */ | ||
| private void startListening() { |
There was a problem hiding this comment.
This diff has ended up looking pretty confusing. I'm just moving this listening logic out of the constructor and into a separate method. I also did some reordering of the constructor logic so that it reads better.
shemnon
approved these changes
May 8, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Start listening for incoming p2p connections only after start() is invoked. Additionally, since we're no longer setting up listening in the constructor, we can now gate the stop() method so that it only runs after the network has been started.