This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Allow config files to specify no bootnodes #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Pantheon allows
--bootnodeson the command line to specify no boot nodes (useful if this node is the boot node) but the equivalent in a config file (bootnodes=[]) resulted in an invalid enode URI error.This fixes
PantheonCommandso that it filters out empty values for bootnodes which makes the config work and is generally more userfriendly (accidentally using a double-comma in a bootnodes argument now also works).