This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2647] Validate Private Transaction nonce before submitting to Transaction Pool #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
force-pushed
the
validateTx
branch
4 times, most recently
from
9c75581 to
8ae8c72
Compare
|
@Puneetha17 please review |
Puneetha17
reviewed
May 15, 2019
...eum/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionHandler.java
Outdated
Show resolved
Hide resolved
...rpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/response/JsonRpcError.java
Outdated
Show resolved
Hide resolved
|
LGTM |
enclave/src/main/java/tech/pegasys/pantheon/enclave/Enclave.java
Outdated
Show resolved
Hide resolved
iikirilov
force-pushed
the
validateTx
branch
7 times, most recently
from
bab08f8 to
5835ae5
Compare
ekellstrand
reviewed
May 20, 2019
enclave/src/main/java/tech/pegasys/pantheon/enclave/Enclave.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/TransactionValidator.java
Show resolved
Hide resolved
...eum/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionHandler.java
Outdated
Show resolved
Hide resolved
...core/src/test/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionHandlerTest.java
Outdated
Show resolved
Hide resolved
...a/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/privacy/EeaSendRawTransaction.java
Show resolved
Hide resolved
ekellstrand
approved these changes
May 22, 2019
...eum/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionHandler.java
Outdated
Show resolved
Hide resolved
iikirilov
force-pushed
the
validateTx
branch
2 times, most recently
from
a0858f3 to
aa457e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Validates the Private Transaction nonce before submitting to the Transaction Pool.
Returns
PRIVATE_NONCE_TOO_LOWorINCORRECT_PRIVATE_NONCEif the nonce is not validFixed Issue(s)
PAN-2647